lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wan/hdlc_x25.c: fix a NULL dereference

Browse Source 
WAN: fixes a NULL dereference in hdlc_x25.

Reported-by: Adrian Bunk <bunk@kernel.org>.
Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Krzysztof Halasa
2008-09-03 18:21:56 +02:00
committed by Jeff Garzik
parent 2d1ea19da0
commit 5406951163
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/wan/hdlc_x25.c
View File

@@ -163,15 +163,17 @@ static void x25_close(struct net_device *dev)
static int x25_rx(struct sk_buff *skb) static int x25_rx(struct sk_buff *skb)
{ {
struct net_device *dev = skb->dev;
if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) { if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) {
skb->dev->stats.rx_dropped++; dev->stats.rx_dropped++;
return NET_RX_DROP; return NET_RX_DROP;
} }
if (lapb_data_received(skb->dev, skb) == LAPB_OK) if (lapb_data_received(dev, skb) == LAPB_OK)
return NET_RX_SUCCESS; return NET_RX_SUCCESS;
skb->dev->stats.rx_errors++; dev->stats.rx_errors++;
dev_kfree_skb_any(skb); dev_kfree_skb_any(skb);
return NET_RX_DROP; return NET_RX_DROP;
} }