lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

uio: remove redundant check

Browse Source 
It is not necessary to check idev->info several times under
mutex lock, so just remove redundant check.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Chengguang Xu 2019-01-19 21:15:34 +08:00 committed by Greg Kroah-Hartman
parent 1e09cdd506
commit 54557665a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/uio/uio.c
View File

@ -494,7 +494,7 @@ static int uio_open(struct inode *inode, struct file *filep)
goto err_infoopen;
}
if (idev->info && idev->info->open)
if (idev->info->open)
ret = idev->info->open(idev->info, inode);
mutex_unlock(&idev->info_lock);
if (ret)
@ -635,7 +635,7 @@ static ssize_t uio_write(struct file *filep, const char __user *buf,
goto out;
}
if (!idev->info || !idev->info->irq) {
if (!idev->info->irq) {
retval = -EIO;
goto out;
}