lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ALSA: hda - Fix parse of init_verbs sysfs entry

Browse Source 
Fixed the parse of init_verbs hwdep sysfs entry.
Simplieied using sscanf.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai
2009-02-20 15:59:01 +01:00
parent d14a7e0bfc
commit 55290e1932
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
sound/pci/hda/hda_hwdep.c
View File

@@ -277,18 +277,19 @@ static ssize_t init_verbs_store(struct device *dev,
{ {
struct snd_hwdep *hwdep = dev_get_drvdata(dev); struct snd_hwdep *hwdep = dev_get_drvdata(dev);
struct hda_codec *codec = hwdep->private_data; struct hda_codec *codec = hwdep->private_data;
char *p; struct hda_verb *v;
struct hda_verb verb, *v; int nid, verb, param;
verb.nid = simple_strtoul(buf, &p, 0); if (sscanf(buf, "%i %i %i", &nid, &verb, &param) != 3)
verb.verb = simple_strtoul(p, &p, 0); return -EINVAL;
verb.param = simple_strtoul(p, &p, 0); if (!nid || !verb)
if (!verb.nid || !verb.verb || !verb.param)
return -EINVAL; return -EINVAL;
v = snd_array_new(&codec->init_verbs); v = snd_array_new(&codec->init_verbs);
if (!v) if (!v)
return -ENOMEM; return -ENOMEM;
*v = verb; v->nid = nid;
v->verb = verb;
v->param = param;
return count; return count;
} }