lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sh: panic on machvec section misalignment.

Browse Source 
Now that __initmv references the machvec section unconditionally
there have been cases where folks have been mistakenly flagging
non-machvec structures with the machvec section attribute (presumably
to shut up modpost). This leads to obscure breakage in earlyprintk
amongst other places and is rather non-obvious.

Add a simple sanity check to try and catch __initmv misuse and
panic early.

Reported-by: Markus Brunner <super.firetwister@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Paul Mundt
2007-08-07 19:13:23 +09:00
parent 662ae2169a
commit 5556410e22
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
arch/sh/kernel/machvec.c
View File

@@ -90,6 +90,13 @@ void __init sh_mv_setup(void)
machvec_size = ((unsigned long)&__machvec_end - machvec_size = ((unsigned long)&__machvec_end -
(unsigned long)&__machvec_start); (unsigned long)&__machvec_start);
/*
* Sanity check for machvec section alignment. Ensure
* __initmv hasn't been misused.
*/
if (machvec_size % sizeof(struct sh_machine_vector))
panic("machvec misaligned, invalid __initmv use?");
/* /*
* If the machvec hasn't been preselected, use the first * If the machvec hasn't been preselected, use the first
* vector (usually the only one) from .machvec.init. * vector (usually the only one) from .machvec.init.