lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "kernfs: invoke kernfs_unmap_bin_file() directly from __kernfs_remove()"

Browse Source 
This reverts commit f601f9a2bf.

Tejun writes:
        I'm sorry but can you please revert the whole series?
        get_active() waiting while a node is deactivated has potential
        to lead to deadlock and that deactivate/reactivate interface is
        something fundamentally flawed and that cgroup will have to work
        with the remove_self() like everybody else.  IOW, I think the
        first posting was correct.

Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman
2014-01-13 14:27:16 -08:00
parent 7653fe9d6c
commit 55f6e30d0a
3 changed files with 14 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
fs/kernfs/file.c
View File

@@ -700,11 +700,14 @@ static int kernfs_fop_release(struct inode *inode, struct file *filp)
return 0;
}
void kernfs_unmap_file(struct kernfs_node *kn)
void kernfs_unmap_bin_file(struct kernfs_node *kn)
{
struct kernfs_open_node *on;
struct kernfs_open_file *of;
if (!(kn->flags & KERNFS_HAS_MMAP))
return;
spin_lock_irq(&kernfs_open_node_lock);
on = kn->attr.open;
if (on)