lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libata-sff: fix ata_sff_post_internal_cmd()

Browse Source 
ata_sff_post_internal_cmd() needs to grab port lock before calling
ata_bmdma_stop() and also need to clear hsm_task_state.  Fix it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Tejun Heo
2008-10-20 13:10:21 +09:00
committed by Jeff Garzik
parent f667fdbbbe
commit 570106df6b
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/ata/libata-sff.c
View File

@@ -2153,8 +2153,17 @@ void ata_sff_error_handler(struct ata_port *ap)
*/ */
void ata_sff_post_internal_cmd(struct ata_queued_cmd *qc) void ata_sff_post_internal_cmd(struct ata_queued_cmd *qc)
{ {
if (qc->ap->ioaddr.bmdma_addr) struct ata_port *ap = qc->ap;
unsigned long flags;
spin_lock_irqsave(ap->lock, flags);
ap->hsm_task_state = HSM_ST_IDLE;
if (ap->ioaddr.bmdma_addr)
ata_bmdma_stop(qc); ata_bmdma_stop(qc);
spin_unlock_irqrestore(ap->lock, flags);
} }
/** /**