lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pnfsblock: clean up _add_entry

Browse Source 
It is wrong to kmalloc in _add_entry() as it is inside
spinlock. memory should be already allocated _add_entry() is called.

Signed-off-by: Peng Tao <peng_tao@emc.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Peng Tao
2012-01-12 23:18:45 +08:00
committed by Trond Myklebust
parent 82b906d655
commit 57582b372f
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fs/nfs/blocklayout/extents.c
View File

@@ -110,13 +110,7 @@ static int _add_entry(struct my_tree *tree, u64 s, int32_t tag,
return 0; return 0;
} else { } else {
struct pnfs_inval_tracking *new; struct pnfs_inval_tracking *new;
if (storage) new = storage;
new = storage;
else {
new = kmalloc(sizeof(*new), GFP_NOFS);
if (!new)
return -ENOMEM;
}
new->it_sector = s; new->it_sector = s;
new->it_tags = (1 << tag); new->it_tags = (1 << tag);
list_add(&new->it_link, &pos->it_link); list_add(&new->it_link, &pos->it_link);