lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: panel: fix oops on panel_cleanup_module

Browse Source 
Check for null pardevice (not registered, ej: panel never attached,
inexistent parport, etc. )  before calling parport_release,
parport_unregister_device, and related funcs on module release.

Signed-off-by: Costantino Leandro <lcostantino@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Costantino Leandro
2009-02-17 11:10:48 -05:00
committed by Greg Kroah-Hartman
parent 096c55d1de
commit 5789813e73
1 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/panel/panel.c
View File

@@ -2164,6 +2164,7 @@ static void __exit panel_cleanup_module(void)
if (scan_timer.function != NULL) if (scan_timer.function != NULL)
del_timer(&scan_timer); del_timer(&scan_timer);
if (pprt != NULL) {
if (keypad_enabled) if (keypad_enabled)
misc_deregister(&keypad_dev); misc_deregister(&keypad_dev);
@@ -2174,9 +2175,9 @@ static void __exit panel_cleanup_module(void)
} }
/* TODO: free all input signals */ /* TODO: free all input signals */
parport_release(pprt); parport_release(pprt);
parport_unregister_device(pprt); parport_unregister_device(pprt);
}
parport_unregister_driver(&panel_driver); parport_unregister_driver(&panel_driver);
} }