lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: dgap: driver.c: removes smatch warning "redundant null check"

Browse Source 
This patch removes these smatch warnings from dgap_driver.c:

redundant null check on dgap_config_buf calling kfree()
redundant null check on brd->flipbuf calling kfree()
redundant null check on brd->flipflagbuf calling kfree()

Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Lidza Louina 2013-09-23 18:47:12 -04:00 committed by Greg Kroah-Hartman
parent 6319c61aec
commit 57a42192e6
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/dgap/dgap_driver.c
View File

@ -416,8 +416,7 @@ void dgap_cleanup_module(void)
unregister_chrdev(DIGI_DGAP_MAJOR, "dgap");
}
if (dgap_config_buf)
kfree(dgap_config_buf);
kfree(dgap_config_buf);
for (i = 0; i < dgap_NumBoards; ++i) {
dgap_remove_ports_sysfiles(dgap_Board[i]);
@ -484,10 +483,8 @@ static void dgap_cleanup_board(struct board_t *brd)
}
}
if (brd->flipbuf)
kfree(brd->flipbuf);
if (brd->flipflagbuf)
kfree(brd->flipflagbuf);
kfree(brd->flipbuf);
kfree(brd->flipflagbuf);
dgap_Board[brd->boardnum] = NULL;