lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

udf: Do not read inode before writing it

Browse Source 
We needlessly read inode in udf_update_inode just before zeroing out the
contents of the buffer. Fix it.

Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Jan Kara
2010-01-08 16:52:59 +01:00
parent aae917cd18
commit 5833ded9b6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/udf/inode.c
View File

@@ -1408,9 +1408,8 @@ static int udf_update_inode(struct inode *inode, int do_sync)
unsigned char blocksize_bits = inode->i_sb->s_blocksize_bits; unsigned char blocksize_bits = inode->i_sb->s_blocksize_bits;
struct udf_inode_info *iinfo = UDF_I(inode); struct udf_inode_info *iinfo = UDF_I(inode);
bh = udf_tread(inode->i_sb, bh = udf_tgetblk(inode->i_sb,
udf_get_lb_pblock(inode->i_sb, udf_get_lb_pblock(inode->i_sb, &iinfo->i_location, 0));
&iinfo->i_location, 0));
if (!bh) { if (!bh) {
udf_debug("getblk failure\n"); udf_debug("getblk failure\n");
return -ENOMEM; return -ENOMEM;
@@ -1602,6 +1601,7 @@ static int udf_update_inode(struct inode *inode, int do_sync)
fe->descTag.tagChecksum = udf_tag_checksum(&fe->descTag); fe->descTag.tagChecksum = udf_tag_checksum(&fe->descTag);
out: out:
set_buffer_uptodate(bh);
unlock_buffer(bh); unlock_buffer(bh);
/* write the data blocks */ /* write the data blocks */