lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] coverity: idr_get_new_above_int() overrun fix

Browse Source 
This patch fixes overrun of array pa:
92   		struct idr_layer *pa[MAX_LEVEL];

in

98   		l = idp->layers;
99   		pa[l--] = NULL;

by passing idp->layers, set in
202  		idp->layers = layers;
to function  sub_alloc in
203  		v = sub_alloc(idp, ptr, &id);

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Zaur Kambarov
2005-06-21 17:14:31 -07:00
committed by Linus Torvalds
parent 3a845099b2
commit 589777eab7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/idr.c
View File

@@ -175,7 +175,7 @@ build_up:
* Add a new layer to the top of the tree if the requested * Add a new layer to the top of the tree if the requested
* id is larger than the currently allocated space. * id is larger than the currently allocated space.
*/ */
while ((layers < MAX_LEVEL) && (id >= (1 << (layers*IDR_BITS)))) { while ((layers < (MAX_LEVEL - 1)) && (id >= (1 << (layers*IDR_BITS)))) {
layers++; layers++;
if (!p->count) if (!p->count)
continue; continue;