niu: Fix error handling
platform_device_register_simple() returns ERR_PTR(), not NULL, if an error occurs. Found by smatch (http://repo.or.cz/w/smatch.git). Compile tested. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
b5e86db4c7
commit
58f3e0a864
@@ -9542,7 +9542,7 @@ static struct niu_parent * __devinit niu_new_parent(struct niu *np,
|
|||||||
|
|
||||||
plat_dev = platform_device_register_simple("niu", niu_parent_index,
|
plat_dev = platform_device_register_simple("niu", niu_parent_index,
|
||||||
NULL, 0);
|
NULL, 0);
|
||||||
if (!plat_dev)
|
if (IS_ERR(plat_dev))
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
for (i = 0; attr_name(niu_parent_attributes[i]); i++) {
|
for (i = 0; attr_name(niu_parent_attributes[i]); i++) {
|
||||||
|
Reference in New Issue
Block a user