lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

e1000: check return value of _get_speed_and_duplex

Browse Source 
We were not checking the return value of get_speed_and_duplex
properly, whih may contain an error value.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
This commit is contained in:
Auke Kok
2006-06-27 09:08:09 -07:00
committed by Auke Kok
parent ee04022a21
commit 592600a053
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/e1000/e1000_hw.c
View File

@@ -2737,7 +2737,11 @@ e1000_check_for_link(struct e1000_hw *hw)
*/ */
if(hw->tbi_compatibility_en) { if(hw->tbi_compatibility_en) {
uint16_t speed, duplex; uint16_t speed, duplex;
e1000_get_speed_and_duplex(hw, &speed, &duplex); ret_val = e1000_get_speed_and_duplex(hw, &speed, &duplex);
if (ret_val) {
DEBUGOUT("Error getting link speed and duplex\n");
return ret_val;
}
if (speed != SPEED_1000) { if (speed != SPEED_1000) {
/* If link speed is not set to gigabit speed, we do not need /* If link speed is not set to gigabit speed, we do not need
* to enable TBI compatibility. * to enable TBI compatibility.