lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

block: remove support for bio remapping from ->make_request

Browse Source 
There is very little benefit in allowing to let a ->make_request
instance update the bios device and sector and loop around it in
__generic_make_request when we can archive the same through calling
generic_make_request from the driver and letting the loop in
generic_make_request handle it.

Note that various drivers got the return value from ->make_request and
returned non-zero values for errors.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
This commit is contained in:
Christoph Hellwig
2011-09-12 12:12:01 +02:00
committed by Jens Axboe
parent c20e8de27f
commit 5a7bbad27a
25 changed files with 155 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/md/raid1.c
View File

@ -785,7 +785,7 @@ do_sync_io:
PRINTK("%dB behind alloc failed, doing sync I/O\n", bio->bi_size);
}
static int make_request(mddev_t *mddev, struct bio * bio)
static void make_request(mddev_t *mddev, struct bio * bio)
{
conf_t *conf = mddev->private;
mirror_info_t *mirror;
@ -870,7 +870,7 @@ read_again:
if (rdisk < 0) {
/* couldn't find anywhere to read from */
raid_end_bio_io(r1_bio);
return 0;
return;
}
mirror = conf->mirrors + rdisk;
@ -928,7 +928,7 @@ read_again:
goto read_again;
} else
generic_make_request(read_bio);
return 0;
return;
}
/*
@ -1119,8 +1119,6 @@ read_again:
if (do_sync || !bitmap || !plugged)
md_wakeup_thread(mddev->thread);
return 0;
}
static void status(struct seq_file *seq, mddev_t *mddev)