lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

backlight: atmel-pwm-bl: use gpio_is_valid

Browse Source 
Use gpio_is_valid rather than open coding the more restrictive != -1
test.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Johan Hovold
2013-11-12 15:09:44 -08:00
committed by Linus Torvalds
parent 7bb8abe6ed
commit 5ada4550e8
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/video/backlight/atmel-pwm-bl.c
View File

@@ -48,7 +48,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
pwm_duty = pwmbl->pdata->pwm_duty_min; pwm_duty = pwmbl->pdata->pwm_duty_min;
if (!intensity) { if (!intensity) {
if (pwmbl->gpio_on != -1) { if (gpio_is_valid(pwmbl->gpio_on)) {
gpio_set_value(pwmbl->gpio_on, gpio_set_value(pwmbl->gpio_on,
0 ^ pwmbl->pdata->on_active_low); 0 ^ pwmbl->pdata->on_active_low);
} }
@@ -57,7 +57,7 @@ static int atmel_pwm_bl_set_intensity(struct backlight_device *bd)
} else { } else {
pwm_channel_enable(&pwmbl->pwmc); pwm_channel_enable(&pwmbl->pwmc);
pwm_channel_writel(&pwmbl->pwmc, PWM_CUPD, pwm_duty); pwm_channel_writel(&pwmbl->pwmc, PWM_CUPD, pwm_duty);
if (pwmbl->gpio_on != -1) { if (gpio_is_valid(pwmbl->gpio_on)) {
gpio_set_value(pwmbl->gpio_on, gpio_set_value(pwmbl->gpio_on,
1 ^ pwmbl->pdata->on_active_low); 1 ^ pwmbl->pdata->on_active_low);
} }
@@ -146,7 +146,7 @@ static int atmel_pwm_bl_probe(struct platform_device *pdev)
if (retval) if (retval)
return retval; return retval;
if (pwmbl->gpio_on != -1) { if (gpio_is_valid(pwmbl->gpio_on)) {
retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on, retval = devm_gpio_request(&pdev->dev, pwmbl->gpio_on,
"gpio_atmel_pwm_bl"); "gpio_atmel_pwm_bl");
if (retval) if (retval)
@@ -196,7 +196,7 @@ static int atmel_pwm_bl_remove(struct platform_device *pdev)
{ {
struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev); struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
if (pwmbl->gpio_on != -1) { if (gpio_is_valid(pwmbl->gpio_on)) {
gpio_set_value(pwmbl->gpio_on, gpio_set_value(pwmbl->gpio_on,
0 ^ pwmbl->pdata->on_active_low); 0 ^ pwmbl->pdata->on_active_low);
} }