lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dm log: introduce flush_failed variable

Browse Source 
Introduce "flush failed" variable.  When a flush before clearing a bit
in the log fails, we don't know anything about which which regions are
in-sync and which not.

So we need to set all regions as not-in-sync and set the variable
"flush_failed" to prevent setting the in-sync bit in the future.

A target reload is the only way to get out of this situation.

The variable will be set in following patches.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
This commit is contained in:
Mikulas Patocka
2009-12-10 23:52:00 +00:00
committed by Alasdair G Kergon
parent 20a34a8ecc
commit 5adc78d0d2
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/md/dm-log.c
View File

@@ -210,6 +210,7 @@ struct log_c {
struct dm_target *ti; struct dm_target *ti;
int touched_dirtied; int touched_dirtied;
int touched_cleaned; int touched_cleaned;
int flush_failed;
uint32_t region_size; uint32_t region_size;
unsigned int region_count; unsigned int region_count;
region_t sync_count; region_t sync_count;
@@ -394,6 +395,7 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
lc->ti = ti; lc->ti = ti;
lc->touched_dirtied = 0; lc->touched_dirtied = 0;
lc->touched_cleaned = 0; lc->touched_cleaned = 0;
lc->flush_failed = 0;
lc->region_size = region_size; lc->region_size = region_size;
lc->region_count = region_count; lc->region_count = region_count;
lc->sync = sync; lc->sync = sync;
@@ -706,7 +708,8 @@ static void core_mark_region(struct dm_dirty_log *log, region_t region)
static void core_clear_region(struct dm_dirty_log *log, region_t region) static void core_clear_region(struct dm_dirty_log *log, region_t region)
{ {
struct log_c *lc = (struct log_c *) log->context; struct log_c *lc = (struct log_c *) log->context;
log_set_bit(lc, lc->clean_bits, region); if (likely(!lc->flush_failed))
log_set_bit(lc, lc->clean_bits, region);
} }
static int core_get_resync_work(struct dm_dirty_log *log, region_t *region) static int core_get_resync_work(struct dm_dirty_log *log, region_t *region)