lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

sh: clkfwk: Fix up rate rounding error handling.

Browse Source 
According to the linux/clk.h definition we should be handing back an
errno value or a valid rate. This fixes up the case where 0 can be
returned for invalid frequencies or cases where rounding has no
selectable candidate.

Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
This commit is contained in:
Paul Mundt
2010-11-01 15:30:31 -04:00
parent 3985c7ce85
commit 5aefa34fad
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/sh/clk/core.c
View File

@@ -90,8 +90,8 @@ struct clk_rate_round_data {
static long clk_rate_round_helper(struct clk_rate_round_data *rounder) static long clk_rate_round_helper(struct clk_rate_round_data *rounder)
{ {
unsigned long rate_error, rate_error_prev = ~0UL; unsigned long rate_error, rate_error_prev = ~0UL;
unsigned long rate_best_fit = rounder->rate;
unsigned long highest, lowest, freq; unsigned long highest, lowest, freq;
long rate_best_fit = -ENOENT;
int i; int i;
highest = 0; highest = 0;
@@ -146,7 +146,7 @@ long clk_rate_table_round(struct clk *clk,
}; };
if (clk->nr_freqs < 1) if (clk->nr_freqs < 1)
return 0; return -ENOSYS;
return clk_rate_round_helper(&table_round); return clk_rate_round_helper(&table_round);
} }