lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf debug: Simplify trace_event

Browse Source 
No need to check that many times if debug_trace is on.

Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2010-11-30 17:48:53 -02:00
parent 5c891f3840
commit 5b1c144475
1 changed files with 13 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tools/perf/util/debug.c
View File

@@ -57,21 +57,6 @@ void ui__warning(const char *format, ...)
} }
#endif #endif
static int dump_printf_color(const char *fmt, const char *color, ...)
{
va_list args;
int ret = 0;
if (dump_trace) {
va_start(args, color);
ret = color_vfprintf(stdout, color, fmt, args);
va_end(args);
}
return ret;
}
void trace_event(event_t *event) void trace_event(event_t *event)
{ {
unsigned char *raw_event = (void *)event; unsigned char *raw_event = (void *)event;
@@ -81,29 +66,29 @@ void trace_event(event_t *event)
if (!dump_trace) if (!dump_trace)
return; return;
dump_printf("."); printf(".");
dump_printf_color("\n. ... raw event: size %d bytes\n", color, color_fprintf(stdout, color, "\n. ... raw event: size %d bytes\n",
event->header.size); event->header.size);
for (i = 0; i < event->header.size; i++) { for (i = 0; i < event->header.size; i++) {
if ((i & 15) == 0) { if ((i & 15) == 0) {
dump_printf("."); printf(".");
dump_printf_color(" %04x: ", color, i); color_fprintf(stdout, color, " %04x: ", i);
} }
dump_printf_color(" %02x", color, raw_event[i]); color_fprintf(stdout, color, " %02x", raw_event[i]);
if (((i & 15) == 15) || i == event->header.size-1) { if (((i & 15) == 15) || i == event->header.size-1) {
dump_printf_color(" ", color); color_fprintf(stdout, color, " ");
for (j = 0; j < 15-(i & 15); j++) for (j = 0; j < 15-(i & 15); j++)
dump_printf_color(" ", color); color_fprintf(stdout, color, " ");
for (j = i & ~15; j <= i; j++) { for (j = i & ~15; j <= i; j++) {
dump_printf_color("%c", color, color_fprintf(stdout, color, "%c",
isprint(raw_event[j]) ? isprint(raw_event[j]) ?
raw_event[j] : '.'); raw_event[j] : '.');
} }
dump_printf_color("\n", color); color_fprintf(stdout, color, "\n");
} }
} }
dump_printf(".\n"); printf(".\n");
} }