lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

netdev: Remove warning from __netif_schedule().

Browse Source 
It isn't helping anything and we aren't going to be able to change all
the drivers that do queue wakeups in strange situations.

Just letting a noop_qdisc get scheduled will work because when
qdisc_run() executes via net_tx_work() it will simply find no packets
pending when it makes the ->dequeue() call in qdisc_restart.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller
2008-07-23 14:01:29 -07:00
parent 8a6d2ea0cd
commit 5b3ab1dbd4
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
net/core/dev.c
View File

@@ -1341,9 +1341,6 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev)
void __netif_schedule(struct Qdisc *q) void __netif_schedule(struct Qdisc *q)
{ {
if (WARN_ON_ONCE(q == &noop_qdisc))
return;
if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) { if (!test_and_set_bit(__QDISC_STATE_SCHED, &q->state)) {
struct softnet_data *sd; struct softnet_data *sd;
unsigned long flags; unsigned long flags;