lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

V4L/DVB (11515): drivers/media/video/saa5249.c: fix use-after-free and leak

Browse Source 
I moved the kfree() down a couple lines.  t->vdev is going to be in freed
memory so there is no point setting it to NULL.  I added a kfree(t) on a

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter
2009-04-14 19:50:33 -03:00
committed by Mauro Carvalho Chehab
parent 3964b58a25
commit 5b83cfa985
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/video/saa5249.c
View File

@@ -598,6 +598,7 @@ static int saa5249_probe(struct i2c_client *client,
/* Now create a video4linux device */ /* Now create a video4linux device */
t->vdev = video_device_alloc(); t->vdev = video_device_alloc();
if (t->vdev == NULL) { if (t->vdev == NULL) {
kfree(t);
kfree(client); kfree(client);
return -ENOMEM; return -ENOMEM;
} }
@@ -617,9 +618,8 @@ static int saa5249_probe(struct i2c_client *client,
/* Register it */ /* Register it */
err = video_register_device(t->vdev, VFL_TYPE_VTX, -1); err = video_register_device(t->vdev, VFL_TYPE_VTX, -1);
if (err < 0) { if (err < 0) {
kfree(t);
video_device_release(t->vdev); video_device_release(t->vdev);
t->vdev = NULL; kfree(t);
return err; return err;
} }
return 0; return 0;