lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dell-wmi: sys_init_module: 'dell_wmi'->init suspiciously returned 21, it should follow 0/-E convention

Browse Source 
wmi_install_notify_handler() returns an acpi_error,
but dell_wmi_init() needs return a -errno style error.

Signed-off-by: Len Brown <len.brown@intel.com>
Tested-by: Paul Rolland <rol@as2917.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Len Brown
2009-12-30 01:21:42 -05:00
committed by Linus Torvalds
parent b58454ec25
commit 5ccf73bb4d
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/platform/x86/dell-wmi.c
View File

@@ -323,6 +323,7 @@ static int __init dell_wmi_input_setup(void)
static int __init dell_wmi_init(void) static int __init dell_wmi_init(void)
{ {
int err; int err;
acpi_status status;
if (wmi_has_guid(DELL_EVENT_GUID)) { if (wmi_has_guid(DELL_EVENT_GUID)) {
printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n"); printk(KERN_WARNING "dell-wmi: No known WMI GUID found\n");
@@ -336,14 +337,14 @@ static int __init dell_wmi_init(void)
if (err) if (err)
return err; return err;
err = wmi_install_notify_handler(DELL_EVENT_GUID, status = wmi_install_notify_handler(DELL_EVENT_GUID,
dell_wmi_notify, NULL); dell_wmi_notify, NULL);
if (err) { if (ACPI_FAILURE(status)) {
input_unregister_device(dell_wmi_input_dev); input_unregister_device(dell_wmi_input_dev);
printk(KERN_ERR printk(KERN_ERR
"dell-wmi: Unable to register notify handler - %d\n", "dell-wmi: Unable to register notify handler - %d\n",
err); status);
return err; return -ENODEV;
} }
return 0; return 0;