lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ARM: 6878/1: fix personality flag propagation across an exec

Browse Source 
Our SET_PERSONALITY() implementation was overwriting all existing
personality flags, including ADDR_NO_RANDOMIZE, making them unavailable
to processes being exec'd after a call to personality() in user space.
This prevents the gdb test suite from running successfully.

Signed-off-by: Nicolas Pitre <nicolas.pitre@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
This commit is contained in:
Nicolas Pitre
2011-04-13 04:59:36 +01:00
committed by Russell King
parent df5419a9a9
commit 5e143436d0
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
arch/arm/kernel/elf.c
View File

@@ -40,15 +40,22 @@ EXPORT_SYMBOL(elf_check_arch);
void elf_set_personality(const struct elf32_hdr *x) void elf_set_personality(const struct elf32_hdr *x)
{ {
unsigned int eflags = x->e_flags; unsigned int eflags = x->e_flags;
unsigned int personality = PER_LINUX_32BIT; unsigned int personality = current->personality & ~PER_MASK;
/*
* We only support Linux ELF executables, so always set the
* personality to LINUX.
*/
personality |= PER_LINUX;
/* /*
* APCS-26 is only valid for OABI executables * APCS-26 is only valid for OABI executables
*/ */
if ((eflags & EF_ARM_EABI_MASK) == EF_ARM_EABI_UNKNOWN) { if ((eflags & EF_ARM_EABI_MASK) == EF_ARM_EABI_UNKNOWN &&
if (eflags & EF_ARM_APCS_26) (eflags & EF_ARM_APCS_26))
personality = PER_LINUX; personality &= ~ADDR_LIMIT_32BIT;
} else
personality |= ADDR_LIMIT_32BIT;
set_personality(personality); set_personality(personality);