[PATCH] remove duplicate get_dentry functions in various places
Various filesystem drivers have grown a get_dentry() function that's a duplicate of lookup_one_len, except that it doesn't take a maximum length argument and doesn't check for \0 or / in the passed in filename. Switch all these places to use lookup_one_len. Signed-off-by: Christoph Hellwig <hch@lst.de> Cc: Greg KH <greg@kroah.com> Cc: Paul Jackson <pj@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
ac20427ef6
commit
5f45f1a78f
@@ -110,16 +110,6 @@ static int debug_fill_super(struct super_block *sb, void *data, int silent)
|
||||
return simple_fill_super(sb, DEBUGFS_MAGIC, debug_files);
|
||||
}
|
||||
|
||||
static struct dentry * get_dentry(struct dentry *parent, const char *name)
|
||||
{
|
||||
struct qstr qstr;
|
||||
|
||||
qstr.name = name;
|
||||
qstr.len = strlen(name);
|
||||
qstr.hash = full_name_hash(name,qstr.len);
|
||||
return lookup_hash(&qstr,parent);
|
||||
}
|
||||
|
||||
static struct super_block *debug_get_sb(struct file_system_type *fs_type,
|
||||
int flags, const char *dev_name,
|
||||
void *data)
|
||||
@@ -157,7 +147,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode,
|
||||
|
||||
*dentry = NULL;
|
||||
down(&parent->d_inode->i_sem);
|
||||
*dentry = get_dentry (parent, name);
|
||||
*dentry = lookup_one_len(name, parent, strlen(name));
|
||||
if (!IS_ERR(dentry)) {
|
||||
if ((mode & S_IFMT) == S_IFDIR)
|
||||
error = debugfs_mkdir(parent->d_inode, *dentry, mode);
|
||||
|
Reference in New Issue
Block a user