lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

caif-hsi: Free flip_buffer at shutdown

Browse Source 
Fix memory leak of RX flip-buffer.

Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
sjur.brandeland@stericsson.com
2012-04-12 08:18:08 +00:00
committed by David S. Miller
parent 5c699fb7d8
commit 5f614e6b70
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/caif/caif_hsi.c
View File

@@ -1210,7 +1210,7 @@ int cfhsi_probe(struct platform_device *pdev)
static void cfhsi_shutdown(struct cfhsi *cfhsi) static void cfhsi_shutdown(struct cfhsi *cfhsi)
{ {
u8 *tx_buf, *rx_buf; u8 *tx_buf, *rx_buf, *flip_buf;
/* Stop TXing */ /* Stop TXing */
netif_tx_stop_all_queues(cfhsi->ndev); netif_tx_stop_all_queues(cfhsi->ndev);
@@ -1234,7 +1234,7 @@ static void cfhsi_shutdown(struct cfhsi *cfhsi)
/* Store bufferes: will be freed later. */ /* Store bufferes: will be freed later. */
tx_buf = cfhsi->tx_buf; tx_buf = cfhsi->tx_buf;
rx_buf = cfhsi->rx_buf; rx_buf = cfhsi->rx_buf;
flip_buf = cfhsi->rx_flip_buf;
/* Flush transmit queues. */ /* Flush transmit queues. */
cfhsi_abort_tx(cfhsi); cfhsi_abort_tx(cfhsi);
@@ -1247,6 +1247,7 @@ static void cfhsi_shutdown(struct cfhsi *cfhsi)
/* Free buffers. */ /* Free buffers. */
kfree(tx_buf); kfree(tx_buf);
kfree(rx_buf); kfree(rx_buf);
kfree(flip_buf);
} }
int cfhsi_remove(struct platform_device *pdev) int cfhsi_remove(struct platform_device *pdev)