lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

SUNRPC: Fix potential race in put_rpccred()

Browse Source 
We have to be careful when we try to unhash the credential in
put_rpccred(), because we're not holding the credcache lock, so the call to
rpcauth_unhash_cred() may fail if someone else has looked the cred up, and
obtained a reference to it.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
This commit is contained in:
Trond Myklebust
2008-10-28 15:21:42 -04:00
parent eac0d18d44
commit 5f707eb429
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/sunrpc/auth.c
View File

@@ -455,7 +455,7 @@ need_lock:
} }
if (test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) == 0) if (test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) == 0)
rpcauth_unhash_cred(cred); rpcauth_unhash_cred(cred);
else if (test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0) { if (test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0) {
cred->cr_expire = jiffies; cred->cr_expire = jiffies;
list_add_tail(&cred->cr_lru, &cred_unused); list_add_tail(&cred->cr_lru, &cred_unused);
number_cred_unused++; number_cred_unused++;