lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

jazzsonic: free irq if sonic_open() fails

Browse Source 
jazzsonic_open() doesn't check sonic_open() return code. If it is error
we must free requested IRQ.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Kulikov Vasiliy
2010-07-10 01:00:35 +00:00
committed by David S. Miller
parent 84ce981a07
commit 62cd69a106
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/net/jazzsonic.c
View File

@@ -82,11 +82,20 @@ static unsigned short known_revisions[] =
static int jazzsonic_open(struct net_device* dev) static int jazzsonic_open(struct net_device* dev)
{ {
if (request_irq(dev->irq, sonic_interrupt, IRQF_DISABLED, "sonic", dev)) { int retval;
printk(KERN_ERR "%s: unable to get IRQ %d.\n", dev->name, dev->irq);
return -EAGAIN; retval = request_irq(dev->irq, sonic_interrupt, IRQF_DISABLED,
"sonic", dev);
if (retval) {
printk(KERN_ERR "%s: unable to get IRQ %d.\n",
dev->name, dev->irq);
return retval;
} }
return sonic_open(dev);
retval = sonic_open(dev);
if (retval)
free_irq(dev->irq, dev);
return retval;
} }
static int jazzsonic_close(struct net_device* dev) static int jazzsonic_close(struct net_device* dev)