lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

xfrm: add severity to printk

Browse Source 
Serious oh sh*t messages converted to WARN().
Add KERN_NOTICE severity to the unknown policy type messages.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
stephen hemminger
2010-05-12 06:37:06 +00:00
committed by David S. Miller
parent 6ff9c3644e
commit 62db5cfd70
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
net/xfrm/xfrm_user.c
View File

@@ -1783,7 +1783,7 @@ static int xfrm_add_pol_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
} else { } else {
// reset the timers here? // reset the timers here?
printk("Dont know what to do with soft policy expire\n"); WARN(1, "Dont know what to do with soft policy expire\n");
} }
km_policy_expired(xp, p->dir, up->hard, current->pid); km_policy_expired(xp, p->dir, up->hard, current->pid);
@@ -1883,7 +1883,7 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
return 0; return 0;
bad_policy: bad_policy:
printk("BAD policy passed\n"); WARN(1, "BAD policy passed\n");
free_state: free_state:
kfree(x); kfree(x);
nomem: nomem:
@@ -2385,8 +2385,9 @@ static int xfrm_send_state_notify(struct xfrm_state *x, struct km_event *c)
case XFRM_MSG_FLUSHSA: case XFRM_MSG_FLUSHSA:
return xfrm_notify_sa_flush(c); return xfrm_notify_sa_flush(c);
default: default:
printk("xfrm_user: Unknown SA event %d\n", c->event); printk(KERN_NOTICE "xfrm_user: Unknown SA event %d\n",
break; c->event);
break;
} }
return 0; return 0;
@@ -2676,7 +2677,8 @@ static int xfrm_send_policy_notify(struct xfrm_policy *xp, int dir, struct km_ev
case XFRM_MSG_POLEXPIRE: case XFRM_MSG_POLEXPIRE:
return xfrm_exp_policy_notify(xp, dir, c); return xfrm_exp_policy_notify(xp, dir, c);
default: default:
printk("xfrm_user: Unknown Policy event %d\n", c->event); printk(KERN_NOTICE "xfrm_user: Unknown Policy event %d\n",
c->event);
} }
return 0; return 0;