[CIFS] formatting fixes
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
committed by
Steve French
parent
0d3a01fada
commit
6345a3a880
@@ -1468,7 +1468,7 @@ ipv4_connect(struct sockaddr_in *psin_server, struct socket **csocket,
|
|||||||
if (psin_server->sin_port) { /* user overrode default port */
|
if (psin_server->sin_port) { /* user overrode default port */
|
||||||
rc = (*csocket)->ops->connect(*csocket,
|
rc = (*csocket)->ops->connect(*csocket,
|
||||||
(struct sockaddr *) psin_server,
|
(struct sockaddr *) psin_server,
|
||||||
sizeof (struct sockaddr_in), 0);
|
sizeof(struct sockaddr_in), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1484,7 +1484,7 @@ ipv4_connect(struct sockaddr_in *psin_server, struct socket **csocket,
|
|||||||
|
|
||||||
rc = (*csocket)->ops->connect(*csocket,
|
rc = (*csocket)->ops->connect(*csocket,
|
||||||
(struct sockaddr *) psin_server,
|
(struct sockaddr *) psin_server,
|
||||||
sizeof (struct sockaddr_in), 0);
|
sizeof(struct sockaddr_in), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1493,7 +1493,7 @@ ipv4_connect(struct sockaddr_in *psin_server, struct socket **csocket,
|
|||||||
psin_server->sin_port = htons(RFC1001_PORT);
|
psin_server->sin_port = htons(RFC1001_PORT);
|
||||||
rc = (*csocket)->ops->connect(*csocket, (struct sockaddr *)
|
rc = (*csocket)->ops->connect(*csocket, (struct sockaddr *)
|
||||||
psin_server,
|
psin_server,
|
||||||
sizeof (struct sockaddr_in), 0);
|
sizeof(struct sockaddr_in), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1601,7 +1601,7 @@ ipv6_connect(struct sockaddr_in6 *psin_server, struct socket **csocket)
|
|||||||
if (psin_server->sin6_port) { /* user overrode default port */
|
if (psin_server->sin6_port) { /* user overrode default port */
|
||||||
rc = (*csocket)->ops->connect(*csocket,
|
rc = (*csocket)->ops->connect(*csocket,
|
||||||
(struct sockaddr *) psin_server,
|
(struct sockaddr *) psin_server,
|
||||||
sizeof (struct sockaddr_in6), 0);
|
sizeof(struct sockaddr_in6), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1617,7 +1617,7 @@ ipv6_connect(struct sockaddr_in6 *psin_server, struct socket **csocket)
|
|||||||
|
|
||||||
rc = (*csocket)->ops->connect(*csocket,
|
rc = (*csocket)->ops->connect(*csocket,
|
||||||
(struct sockaddr *) psin_server,
|
(struct sockaddr *) psin_server,
|
||||||
sizeof (struct sockaddr_in6), 0);
|
sizeof(struct sockaddr_in6), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1625,7 +1625,7 @@ ipv6_connect(struct sockaddr_in6 *psin_server, struct socket **csocket)
|
|||||||
if (!connected) {
|
if (!connected) {
|
||||||
psin_server->sin6_port = htons(RFC1001_PORT);
|
psin_server->sin6_port = htons(RFC1001_PORT);
|
||||||
rc = (*csocket)->ops->connect(*csocket, (struct sockaddr *)
|
rc = (*csocket)->ops->connect(*csocket, (struct sockaddr *)
|
||||||
psin_server, sizeof (struct sockaddr_in6), 0);
|
psin_server, sizeof(struct sockaddr_in6), 0);
|
||||||
if (rc >= 0)
|
if (rc >= 0)
|
||||||
connected = 1;
|
connected = 1;
|
||||||
}
|
}
|
||||||
@@ -1920,7 +1920,7 @@ cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
|
|||||||
return rc;
|
return rc;
|
||||||
} else {
|
} else {
|
||||||
memcpy(&srvTcp->addr.sockAddr, &sin_server,
|
memcpy(&srvTcp->addr.sockAddr, &sin_server,
|
||||||
sizeof (struct sockaddr_in));
|
sizeof(struct sockaddr_in));
|
||||||
atomic_set(&srvTcp->inFlight, 0);
|
atomic_set(&srvTcp->inFlight, 0);
|
||||||
/* BB Add code for ipv6 case too */
|
/* BB Add code for ipv6 case too */
|
||||||
srvTcp->ssocket = csocket;
|
srvTcp->ssocket = csocket;
|
||||||
@@ -2557,7 +2557,7 @@ CIFSNTLMSSPNegotiateSessSetup(unsigned int xid,
|
|||||||
int remaining_words = 0;
|
int remaining_words = 0;
|
||||||
int bytes_returned = 0;
|
int bytes_returned = 0;
|
||||||
int len;
|
int len;
|
||||||
int SecurityBlobLength = sizeof (NEGOTIATE_MESSAGE);
|
int SecurityBlobLength = sizeof(NEGOTIATE_MESSAGE);
|
||||||
PNEGOTIATE_MESSAGE SecurityBlob;
|
PNEGOTIATE_MESSAGE SecurityBlob;
|
||||||
PCHALLENGE_MESSAGE SecurityBlob2;
|
PCHALLENGE_MESSAGE SecurityBlob2;
|
||||||
__u32 negotiate_flags, capabilities;
|
__u32 negotiate_flags, capabilities;
|
||||||
@@ -2881,8 +2881,8 @@ CIFSNTLMSSPNegotiateSessSetup(unsigned int xid,
|
|||||||
}
|
}
|
||||||
static int
|
static int
|
||||||
CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
||||||
char *ntlm_session_key, int ntlmv2_flag,
|
char *ntlm_session_key, int ntlmv2_flag,
|
||||||
const struct nls_table *nls_codepage)
|
const struct nls_table *nls_codepage)
|
||||||
{
|
{
|
||||||
struct smb_hdr *smb_buffer;
|
struct smb_hdr *smb_buffer;
|
||||||
struct smb_hdr *smb_buffer_response;
|
struct smb_hdr *smb_buffer_response;
|
||||||
@@ -2895,7 +2895,7 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
int remaining_words = 0;
|
int remaining_words = 0;
|
||||||
int bytes_returned = 0;
|
int bytes_returned = 0;
|
||||||
int len;
|
int len;
|
||||||
int SecurityBlobLength = sizeof (AUTHENTICATE_MESSAGE);
|
int SecurityBlobLength = sizeof(AUTHENTICATE_MESSAGE);
|
||||||
PAUTHENTICATE_MESSAGE SecurityBlob;
|
PAUTHENTICATE_MESSAGE SecurityBlob;
|
||||||
__u32 negotiate_flags, capabilities;
|
__u32 negotiate_flags, capabilities;
|
||||||
__u16 count;
|
__u16 count;
|
||||||
@@ -2910,8 +2910,8 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
}
|
}
|
||||||
smb_buffer_response = smb_buffer;
|
smb_buffer_response = smb_buffer;
|
||||||
pSMB = (SESSION_SETUP_ANDX *) smb_buffer;
|
pSMB = (SESSION_SETUP_ANDX *)smb_buffer;
|
||||||
pSMBr = (SESSION_SETUP_ANDX *) smb_buffer_response;
|
pSMBr = (SESSION_SETUP_ANDX *)smb_buffer_response;
|
||||||
|
|
||||||
/* send SMBsessionSetup here */
|
/* send SMBsessionSetup here */
|
||||||
header_assemble(smb_buffer, SMB_COM_SESSION_SETUP_ANDX,
|
header_assemble(smb_buffer, SMB_COM_SESSION_SETUP_ANDX,
|
||||||
@@ -2930,7 +2930,7 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
smb_buffer->Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
|
smb_buffer->Flags2 |= SMBFLG2_SECURITY_SIGNATURE;
|
||||||
|
|
||||||
capabilities = CAP_LARGE_FILES | CAP_NT_SMBS | CAP_LEVEL_II_OPLOCKS |
|
capabilities = CAP_LARGE_FILES | CAP_NT_SMBS | CAP_LEVEL_II_OPLOCKS |
|
||||||
CAP_EXTENDED_SECURITY;
|
CAP_EXTENDED_SECURITY;
|
||||||
if (ses->capabilities & CAP_UNICODE) {
|
if (ses->capabilities & CAP_UNICODE) {
|
||||||
smb_buffer->Flags2 |= SMBFLG2_UNICODE;
|
smb_buffer->Flags2 |= SMBFLG2_UNICODE;
|
||||||
capabilities |= CAP_UNICODE;
|
capabilities |= CAP_UNICODE;
|
||||||
@@ -2945,15 +2945,14 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
}
|
}
|
||||||
pSMB->req.Capabilities = cpu_to_le32(capabilities);
|
pSMB->req.Capabilities = cpu_to_le32(capabilities);
|
||||||
|
|
||||||
bcc_ptr = (char *) &pSMB->req.SecurityBlob;
|
bcc_ptr = (char *)&pSMB->req.SecurityBlob;
|
||||||
SecurityBlob = (PAUTHENTICATE_MESSAGE) bcc_ptr;
|
SecurityBlob = (PAUTHENTICATE_MESSAGE)bcc_ptr;
|
||||||
strncpy(SecurityBlob->Signature, NTLMSSP_SIGNATURE, 8);
|
strncpy(SecurityBlob->Signature, NTLMSSP_SIGNATURE, 8);
|
||||||
SecurityBlob->MessageType = NtLmAuthenticate;
|
SecurityBlob->MessageType = NtLmAuthenticate;
|
||||||
bcc_ptr += SecurityBlobLength;
|
bcc_ptr += SecurityBlobLength;
|
||||||
negotiate_flags =
|
negotiate_flags = NTLMSSP_NEGOTIATE_UNICODE | NTLMSSP_REQUEST_TARGET |
|
||||||
NTLMSSP_NEGOTIATE_UNICODE | NTLMSSP_REQUEST_TARGET |
|
NTLMSSP_NEGOTIATE_NTLM | NTLMSSP_NEGOTIATE_TARGET_INFO |
|
||||||
NTLMSSP_NEGOTIATE_NTLM | NTLMSSP_NEGOTIATE_TARGET_INFO |
|
0x80000000 | NTLMSSP_NEGOTIATE_128;
|
||||||
0x80000000 | NTLMSSP_NEGOTIATE_128;
|
|
||||||
if (sign_CIFS_PDUs)
|
if (sign_CIFS_PDUs)
|
||||||
negotiate_flags |= /* NTLMSSP_NEGOTIATE_ALWAYS_SIGN |*/ NTLMSSP_NEGOTIATE_SIGN;
|
negotiate_flags |= /* NTLMSSP_NEGOTIATE_ALWAYS_SIGN |*/ NTLMSSP_NEGOTIATE_SIGN;
|
||||||
if (ntlmv2_flag)
|
if (ntlmv2_flag)
|
||||||
@@ -3104,12 +3103,11 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
rc = SendReceive(xid, ses, smb_buffer, smb_buffer_response,
|
rc = SendReceive(xid, ses, smb_buffer, smb_buffer_response,
|
||||||
&bytes_returned, 1);
|
&bytes_returned, 1);
|
||||||
if (rc) {
|
if (rc) {
|
||||||
/* rc = map_smb_to_linux_error(smb_buffer_response); *//* done in SendReceive now */
|
/* rc = map_smb_to_linux_error(smb_buffer_response) done in SendReceive now */
|
||||||
} else if ((smb_buffer_response->WordCount == 3)
|
} else if ((smb_buffer_response->WordCount == 3) ||
|
||||||
|| (smb_buffer_response->WordCount == 4)) {
|
(smb_buffer_response->WordCount == 4)) {
|
||||||
__u16 action = le16_to_cpu(pSMBr->resp.Action);
|
__u16 action = le16_to_cpu(pSMBr->resp.Action);
|
||||||
__u16 blob_len =
|
__u16 blob_len = le16_to_cpu(pSMBr->resp.SecurityBlobLength);
|
||||||
le16_to_cpu(pSMBr->resp.SecurityBlobLength);
|
|
||||||
if (action & GUEST_LOGIN)
|
if (action & GUEST_LOGIN)
|
||||||
cFYI(1, (" Guest login")); /* BB Should we set anything
|
cFYI(1, (" Guest login")); /* BB Should we set anything
|
||||||
in SesInfo struct ? */
|
in SesInfo struct ? */
|
||||||
@@ -3263,22 +3261,19 @@ CIFSNTLMSSPAuthSessSetup(unsigned int xid, struct cifsSesInfo *ses,
|
|||||||
bcc_ptr[0] = 0;
|
bcc_ptr[0] = 0;
|
||||||
bcc_ptr++;
|
bcc_ptr++;
|
||||||
} else
|
} else
|
||||||
cFYI(1,
|
cFYI(1, ("field of length %d "
|
||||||
("field of length %d "
|
|
||||||
"extends beyond end of smb ",
|
"extends beyond end of smb ",
|
||||||
len));
|
len));
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
cERROR(1,
|
cERROR(1, ("Security Blob extends beyond end "
|
||||||
(" Security Blob extends beyond end "
|
|
||||||
"of SMB"));
|
"of SMB"));
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
cERROR(1, ("No session structure passed in."));
|
cERROR(1, ("No session structure passed in."));
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
cERROR(1,
|
cERROR(1, ("Invalid Word count %d: ",
|
||||||
(" Invalid Word count %d: ",
|
|
||||||
smb_buffer_response->WordCount));
|
smb_buffer_response->WordCount));
|
||||||
rc = -EIO;
|
rc = -EIO;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user