lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] b44: s/spin_lock_irqsave/spin_lock/ in b44_interrupt

Browse Source 
There is no need to save/restore the irq state as the irq are always
locally disabled when b44_interrupt is issued.

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
This commit is contained in:
Francois Romieu
2005-11-07 01:52:06 +01:00
committed by Jeff Garzik
parent 3353930d9d
commit 65b984f26f
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/b44.c
View File

@@ -895,11 +895,10 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id, struct pt_regs *regs)
{ {
struct net_device *dev = dev_id; struct net_device *dev = dev_id;
struct b44 *bp = netdev_priv(dev); struct b44 *bp = netdev_priv(dev);
unsigned long flags;
u32 istat, imask; u32 istat, imask;
int handled = 0; int handled = 0;
spin_lock_irqsave(&bp->lock, flags); spin_lock(&bp->lock);
istat = br32(bp, B44_ISTAT); istat = br32(bp, B44_ISTAT);
imask = br32(bp, B44_IMASK); imask = br32(bp, B44_IMASK);
@@ -925,7 +924,7 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id, struct pt_regs *regs)
bw32(bp, B44_ISTAT, istat); bw32(bp, B44_ISTAT, istat);
br32(bp, B44_ISTAT); br32(bp, B44_ISTAT);
} }
spin_unlock_irqrestore(&bp->lock, flags); spin_unlock(&bp->lock);
return IRQ_RETVAL(handled); return IRQ_RETVAL(handled);
} }