lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: rts_pstor: dont cast void* from kmalloc()

Browse Source 
Casting (void *) value returned by kmalloc is useless
 as mentioned in Documentation/CodingStyle, Chap 14.

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Thomas Meyer
2011-08-13 16:14:03 +02:00
committed by Greg Kroah-Hartman
parent fa2d8bbb63
commit 65f15e2de8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rts_pstor/sd.c
View File

@@ -4139,7 +4139,7 @@ int sd_execute_read_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
cmd[3] = srb->cmnd[5]; cmd[3] = srb->cmnd[5];
cmd[4] = srb->cmnd[6]; cmd[4] = srb->cmnd[6];
buf = (u8 *)kmalloc(data_len, GFP_KERNEL); buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) { if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR); TRACE_RET(chip, TRANSPORT_ERROR);
} }
@@ -4385,7 +4385,7 @@ int sd_execute_write_data(struct scsi_cmnd *srb, struct rtsx_chip *chip)
u16 i; u16 i;
u8 *buf; u8 *buf;
buf = (u8 *)kmalloc(data_len, GFP_KERNEL); buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) { if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR); TRACE_RET(chip, TRANSPORT_ERROR);
} }