lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ALSA: ctxfi - Fix uninitialized error checks

Browse Source 
Fix a few uninitialized error checks that were introduced recently
mistakenlly during the clean-up:
  sound/pci/ctxfi/ctamixer.c: In function ‘get_amixer_rsc’:
  sound/pci/ctxfi/ctamixer.c:261: warning: ‘err’ may be used uninitialized in this function
  sound/pci/ctxfi/ctamixer.c: In function ‘get_sum_rsc’:
  sound/pci/ctxfi/ctamixer.c:415: warning: ‘err’ may be used uninitialized in this function
  sound/pci/ctxfi/ctsrc.c: In function ‘get_srcimp_rsc’:
  sound/pci/ctxfi/ctsrc.c:742: warning: ‘err’ may be used uninitialized in this function

Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Takashi Iwai
2009-07-22 17:05:15 +02:00
parent 55fe27f7e2
commit 68110661e8
2 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sound/pci/ctxfi/ctamixer.c
View File

@@ -242,13 +242,12 @@ static int get_amixer_rsc(struct amixer_mgr *mgr,
/* Allocate mem for amixer resource */ /* Allocate mem for amixer resource */
amixer = kzalloc(sizeof(*amixer), GFP_KERNEL); amixer = kzalloc(sizeof(*amixer), GFP_KERNEL);
if (NULL == amixer) { if (!amixer)
err = -ENOMEM; return -ENOMEM;
return err;
}
/* Check whether there are sufficient /* Check whether there are sufficient
* amixer resources to meet request. */ * amixer resources to meet request. */
err = 0;
spin_lock_irqsave(&mgr->mgr_lock, flags); spin_lock_irqsave(&mgr->mgr_lock, flags);
for (i = 0; i < desc->msr; i++) { for (i = 0; i < desc->msr; i++) {
err = mgr_get_resource(&mgr->mgr, 1, &idx); err = mgr_get_resource(&mgr->mgr, 1, &idx);
@@ -397,12 +396,11 @@ static int get_sum_rsc(struct sum_mgr *mgr,
/* Allocate mem for sum resource */ /* Allocate mem for sum resource */
sum = kzalloc(sizeof(*sum), GFP_KERNEL); sum = kzalloc(sizeof(*sum), GFP_KERNEL);
if (NULL == sum) { if (!sum)
err = -ENOMEM; return -ENOMEM;
return err;
}
/* Check whether there are sufficient sum resources to meet request. */ /* Check whether there are sufficient sum resources to meet request. */
err = 0;
spin_lock_irqsave(&mgr->mgr_lock, flags); spin_lock_irqsave(&mgr->mgr_lock, flags);
for (i = 0; i < desc->msr; i++) { for (i = 0; i < desc->msr; i++) {
err = mgr_get_resource(&mgr->mgr, 1, &idx); err = mgr_get_resource(&mgr->mgr, 1, &idx);

7
sound/pci/ctxfi/ctsrc.c
View File

@@ -724,12 +724,11 @@ static int get_srcimp_rsc(struct srcimp_mgr *mgr,
/* Allocate mem for SRCIMP resource */ /* Allocate mem for SRCIMP resource */
srcimp = kzalloc(sizeof(*srcimp), GFP_KERNEL); srcimp = kzalloc(sizeof(*srcimp), GFP_KERNEL);
if (NULL == srcimp) { if (!srcimp)
err = -ENOMEM; return -ENOMEM;
return err;
}
/* Check whether there are sufficient SRCIMP resources. */ /* Check whether there are sufficient SRCIMP resources. */
err = 0;
spin_lock_irqsave(&mgr->mgr_lock, flags); spin_lock_irqsave(&mgr->mgr_lock, flags);
for (i = 0; i < desc->msr; i++) { for (i = 0; i < desc->msr; i++) {
err = mgr_get_resource(&mgr->mgr, 1, &idx); err = mgr_get_resource(&mgr->mgr, 1, &idx);