gpio: altera-a10sr: Trivial coding style fix
Change the coding style to make it does error checking first. This also fixes checkpatch warning about line over 80 characters. Signed-off-by: Axel Lin <axel.lin@ingics.com> Tested by: Thor Thayer <thor.thayer@linux.intel.com> Reviewed by: Thor Thayer <thor.thayer@linux.intel.com> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This commit is contained in:
parent
6911845227
commit
68b7587baa
@ -58,19 +58,20 @@ static void altr_a10sr_gpio_set(struct gpio_chip *chip, unsigned int offset,
|
|||||||
static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
|
static int altr_a10sr_gpio_direction_input(struct gpio_chip *gc,
|
||||||
unsigned int nr)
|
unsigned int nr)
|
||||||
{
|
{
|
||||||
if (nr >= (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))
|
if (nr < (ALTR_A10SR_IN_VALID_RANGE_LO - ALTR_A10SR_LED_VALID_SHIFT))
|
||||||
return 0;
|
return -EINVAL;
|
||||||
return -EINVAL;
|
|
||||||
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
|
static int altr_a10sr_gpio_direction_output(struct gpio_chip *gc,
|
||||||
unsigned int nr, int value)
|
unsigned int nr, int value)
|
||||||
{
|
{
|
||||||
if (nr <= (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT)) {
|
if (nr > (ALTR_A10SR_OUT_VALID_RANGE_HI - ALTR_A10SR_LED_VALID_SHIFT))
|
||||||
altr_a10sr_gpio_set(gc, nr, value);
|
return -EINVAL;
|
||||||
return 0;
|
|
||||||
}
|
altr_a10sr_gpio_set(gc, nr, value);
|
||||||
return -EINVAL;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct gpio_chip altr_a10sr_gc = {
|
static const struct gpio_chip altr_a10sr_gc = {
|
||||||
|
Loading…
Reference in New Issue
Block a user