lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf tools: Unify debug messages mechanisms

Browse Source 
We were using eprintf in some places, that looks at a global
'verbose' level, and at other places passing a 'v' parameter to
specify the verbosity level, unify it by introducing
pr_{err,warning,debug,etc}, just like in the kernel.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256153646-10097-1-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Arnaldo Carvalho de Melo
2009-10-21 17:34:06 -02:00
committed by Ingo Molnar
parent 802da5f228
commit 6beba7adbe
17 changed files with 114 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tools/perf/util/map.c
View File

@ -21,8 +21,7 @@ static int strcommon(const char *pathname, char *cwd, int cwdlen)
}
struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen,
unsigned int sym_priv_size, symbol_filter_t filter,
int v)
unsigned int sym_priv_size, symbol_filter_t filter)
{
struct map *self = malloc(sizeof(*self));
@ -58,16 +57,16 @@ struct map *map__new(struct mmap_event *event, char *cwd, int cwdlen,
goto out_delete;
if (new_dso) {
int nr = dso__load(self->dso, self, filter, v);
int nr = dso__load(self->dso, self, filter);
if (nr < 0)
eprintf("Failed to open %s, continuing "
"without symbols\n",
self->dso->long_name);
pr_warning("Failed to open %s, continuing "
"without symbols\n",
self->dso->long_name);
else if (nr == 0)
eprintf("No symbols found in %s, maybe "
"install a debug package?\n",
self->dso->long_name);
pr_warning("No symbols found in %s, maybe "
"install a debug package?\n",
self->dso->long_name);
}
if (self->dso == vdso || anon)