lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

push BKL down into ->put_super

Browse Source 
Move BKL into ->put_super from the only caller.  A couple of
filesystems had trivial enough ->put_super (only kfree and NULLing of
s_fs_info + stuff in there) to not get any locking: coda, cramfs, efs,
hugetlbfs, omfs, qnx4, shmem, all others got the full treatment.  Most
of them probably don't need it, but I'd rather sort that out individually.
Preferably after all the other BKL pushdowns in that area.

[AV: original used to move lock_super() down as well; these changes are
removed since we don't do lock_super() at all in generic_shutdown_super()
now]
[AV: fuse, btrfs and xfs are known to need no damn BKL, exempt]

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Christoph Hellwig
2009-05-05 15:40:36 +02:00
committed by Al Viro
parent a9e220f832
commit 6cfd014842
33 changed files with 133 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
fs/super.c
View File

@@ -309,7 +309,6 @@ void generic_shutdown_super(struct super_block *sb)
/* bad name - it should be evict_inodes() */
invalidate_inodes(sb);
lock_kernel();
if (sop->put_super)
sop->put_super(sb);
@@ -320,8 +319,6 @@ void generic_shutdown_super(struct super_block *sb)
"Self-destruct in 5 seconds. Have a nice day...\n",
sb->s_id);
}
unlock_kernel();
put_fs_excl();
}
spin_lock(&sb_lock);