lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

USB: mos7720: remove incorrect read-urb check

Browse Source 
Remove incorrect and unnecessary check for port->read_urb which is not
set to NULL, contrary to what seems to be assumed, when urb is killed.

Compile only-tested.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Johan Hovold
2011-11-06 19:06:26 +01:00
committed by Greg Kroah-Hartman
parent 4556143cab
commit 6d0f41abae
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/usb/serial/mos7720.c
View File

@@ -939,11 +939,6 @@ static void mos7720_bulk_in_callback(struct urb *urb)
} }
tty_kref_put(tty); tty_kref_put(tty);
if (!port->read_urb) {
dbg("URB KILLED !!!");
return;
}
if (port->read_urb->status != -EINPROGRESS) { if (port->read_urb->status != -EINPROGRESS) {
port->read_urb->dev = port->serial->dev; port->read_urb->dev = port->serial->dev;
@@ -1786,11 +1781,6 @@ static void mos7720_set_termios(struct tty_struct *tty,
/* change the port settings to the new ones specified */ /* change the port settings to the new ones specified */
change_port_settings(tty, mos7720_port, old_termios); change_port_settings(tty, mos7720_port, old_termios);
if (!port->read_urb) {
dbg("%s", "URB KILLED !!!!!");
return;
}
if (port->read_urb->status != -EINPROGRESS) { if (port->read_urb->status != -EINPROGRESS) {
port->read_urb->dev = serial->dev; port->read_urb->dev = serial->dev;
status = usb_submit_urb(port->read_urb, GFP_ATOMIC); status = usb_submit_urb(port->read_urb, GFP_ATOMIC);