locks: make posix_test_lock() interface more consistent
Since posix_test_lock(), like fcntl() and ->lock(), indicates absence or presence of a conflict lock by setting fl_type to, respectively, F_UNLCK or something other than F_UNLCK, the return value is no longer needed. Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
This commit is contained in:
10
fs/locks.c
10
fs/locks.c
@@ -659,7 +659,7 @@ static int locks_block_on_timeout(struct file_lock *blocker, struct file_lock *w
|
||||
return result;
|
||||
}
|
||||
|
||||
int
|
||||
void
|
||||
posix_test_lock(struct file *filp, struct file_lock *fl)
|
||||
{
|
||||
struct file_lock *cfl;
|
||||
@@ -671,14 +671,12 @@ posix_test_lock(struct file *filp, struct file_lock *fl)
|
||||
if (posix_locks_conflict(cfl, fl))
|
||||
break;
|
||||
}
|
||||
if (cfl) {
|
||||
if (cfl)
|
||||
__locks_copy_lock(fl, cfl);
|
||||
unlock_kernel();
|
||||
return 1;
|
||||
} else
|
||||
else
|
||||
fl->fl_type = F_UNLCK;
|
||||
unlock_kernel();
|
||||
return 0;
|
||||
return;
|
||||
}
|
||||
|
||||
EXPORT_SYMBOL(posix_test_lock);
|
||||
|
Reference in New Issue
Block a user