lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

nfsd: Drop reference in expkey_parse error cases

Browse Source 
Drop reference to export key on error. Compile tested.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
Krishna Kumar
2008-10-20 11:44:40 +05:30
committed by J. Bruce Fields
parent 6c6a426fdc
commit 6dfcde98a2
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fs/nfsd/export.c
View File

@@ -151,8 +151,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
/* now we want a pathname, or empty meaning NEGATIVE */ /* now we want a pathname, or empty meaning NEGATIVE */
err = -EINVAL; err = -EINVAL;
if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) {
cache_put(&ek->h, &svc_expkey_cache);
goto out; goto out;
}
dprintk("Path seems to be <%s>\n", buf); dprintk("Path seems to be <%s>\n", buf);
err = 0; err = 0;
if (len == 0) { if (len == 0) {
@@ -164,8 +166,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
} else { } else {
struct nameidata nd; struct nameidata nd;
err = path_lookup(buf, 0, &nd); err = path_lookup(buf, 0, &nd);
if (err) if (err) {
cache_put(&ek->h, &svc_expkey_cache);
goto out; goto out;
}
dprintk("Found the path %s\n", buf); dprintk("Found the path %s\n", buf);
key.ek_path = nd.path; key.ek_path = nd.path;