lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] slab: remove broken PageSlab check from kfree_debugcheck

Browse Source 
The PageSlab debug check in kfree_debugcheck() is broken for compound
pages.  It is also redundant as we already do BUG_ON for non-slab pages in
page_get_cache() and page_get_slab() which are always called before we free
any actual objects.

Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Pekka Enberg
2007-02-10 01:42:52 -08:00
committed by Linus Torvalds
parent 66efc5a7e3
commit 6e40e73097
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
mm/slab.c
View File

@@ -2814,19 +2814,11 @@ failed:
*/ */
static void kfree_debugcheck(const void *objp) static void kfree_debugcheck(const void *objp)
{ {
struct page *page;
if (!virt_addr_valid(objp)) { if (!virt_addr_valid(objp)) {
printk(KERN_ERR "kfree_debugcheck: out of range ptr %lxh.\n", printk(KERN_ERR "kfree_debugcheck: out of range ptr %lxh.\n",
(unsigned long)objp); (unsigned long)objp);
BUG(); BUG();
} }
page = virt_to_page(objp);
if (!PageSlab(page)) {
printk(KERN_ERR "kfree_debugcheck: bad ptr %lxh.\n",
(unsigned long)objp);
BUG();
}
} }
static inline void verify_redzone_free(struct kmem_cache *cache, void *obj) static inline void verify_redzone_free(struct kmem_cache *cache, void *obj)