lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] serial moxa: fix wrong BUG

Browse Source 
There is a wrong BUG in mxser_close.

The BUG is triggered when tty->driver_data == NULL, But in fact this is not
a bug, because tty->driver->close is called even when tty->driver->open
fails.

LDD3 tells us to do nothing in such cases.

Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Kirill Smelkov
2005-11-07 00:59:23 -08:00
committed by Linus Torvalds
parent 64698b694d
commit 6f08b72cdd
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/char/mxser.c
View File

@@ -917,6 +917,9 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
struct mxser_struct *info; struct mxser_struct *info;
int retval, line; int retval, line;
/* initialize driver_data in case something fails */
tty->driver_data = NULL;
line = tty->index; line = tty->index;
if (line == MXSER_PORTS) if (line == MXSER_PORTS)
return 0; return 0;
@@ -979,7 +982,7 @@ static void mxser_close(struct tty_struct *tty, struct file *filp)
if (tty->index == MXSER_PORTS) if (tty->index == MXSER_PORTS)
return; return;
if (!info) if (!info)
BUG(); return;
spin_lock_irqsave(&info->slock, flags); spin_lock_irqsave(&info->slock, flags);