macintosh: Don't assume i2c device probing always succeeds
If i2c device probing fails, then there is no driver to dereference after calling i2c_new_device(). Stop assuming that probing will always succeed, to avoid NULL pointer dereferences. We have an easier access to the driver anyway. Signed-off-by: Jean Delvare <khali@linux-fr.org> Tested-by: Tim Shepard <shep@alum.mit.edu> Cc: Colin Leroy <colin@colino.net>
This commit is contained in:
@@ -286,6 +286,8 @@ struct fcu_fan_table fcu_fans[] = {
|
||||
},
|
||||
};
|
||||
|
||||
static struct i2c_driver therm_pm72_driver;
|
||||
|
||||
/*
|
||||
* Utility function to create an i2c_client structure and
|
||||
* attach it to one of u3 adapters
|
||||
@@ -318,7 +320,7 @@ static struct i2c_client *attach_i2c_chip(int id, const char *name)
|
||||
* Let i2c-core delete that device on driver removal.
|
||||
* This is safe because i2c-core holds the core_lock mutex for us.
|
||||
*/
|
||||
list_add_tail(&clt->detected, &clt->driver->clients);
|
||||
list_add_tail(&clt->detected, &therm_pm72_driver.clients);
|
||||
return clt;
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user