lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

net/ipv4/tcp.c: Fix use of PULLHUP instead of POLLHUP in comments.

Browse Source 
Change PULLHUP to POLLHUP in tcp_poll comments and clean up another
comment for grammar and coding style.

Signed-off-by: Will Newton <will.newton@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Will Newton
2008-07-16 20:13:43 -07:00
committed by David S. Miller
parent 7b1c65faa2
commit 70efce27fc
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
net/ipv4/tcp.c
View File

@@ -344,8 +344,8 @@ unsigned int tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
return inet_csk_listen_poll(sk); return inet_csk_listen_poll(sk);
/* Socket is not locked. We are protected from async events /* Socket is not locked. We are protected from async events
by poll logic and correct handling of state changes * by poll logic and correct handling of state changes
made by another threads is impossible in any case. * made by other threads is impossible in any case.
*/ */
mask = 0; mask = 0;
@@ -371,10 +371,10 @@ unsigned int tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
* in state CLOSE_WAIT. One solution is evident --- to set POLLHUP * in state CLOSE_WAIT. One solution is evident --- to set POLLHUP
* if and only if shutdown has been made in both directions. * if and only if shutdown has been made in both directions.
* Actually, it is interesting to look how Solaris and DUX * Actually, it is interesting to look how Solaris and DUX
* solve this dilemma. I would prefer, if PULLHUP were maskable, * solve this dilemma. I would prefer, if POLLHUP were maskable,
* then we could set it on SND_SHUTDOWN. BTW examples given * then we could set it on SND_SHUTDOWN. BTW examples given
* in Stevens' books assume exactly this behaviour, it explains * in Stevens' books assume exactly this behaviour, it explains
* why PULLHUP is incompatible with POLLOUT. --ANK * why POLLHUP is incompatible with POLLOUT. --ANK
* *
* NOTE. Check for TCP_CLOSE is added. The goal is to prevent * NOTE. Check for TCP_CLOSE is added. The goal is to prevent
* blocking on fresh not-connected or disconnected socket. --ANK * blocking on fresh not-connected or disconnected socket. --ANK