lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

writeback: improve readability of the wb_writeback() continue/break logic

Browse Source 
And throw some comments in there, too.

Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Jens Axboe
2009-09-23 19:32:26 +02:00
parent ae1b7f7d4b
commit 71fd05a887
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
fs/fs-writeback.c
View File

@@ -750,29 +750,32 @@ static long wb_writeback(struct bdi_writeback *wb,
wrote += MAX_WRITEBACK_PAGES - wbc.nr_to_write; wrote += MAX_WRITEBACK_PAGES - wbc.nr_to_write;
/* /*
* If we ran out of stuff to write, bail unless more_io got set * If we consumed everything, see if we have more
*/ */
if (wbc.nr_to_write > 0) { if (wbc.nr_to_write <= 0)
if (wbc.more_io) { continue;
if (wbc.nr_to_write < MAX_WRITEBACK_PAGES) /*
continue; * Didn't write everything and we don't have more IO, bail
/* */
* Nothing written. Wait for some inode to if (!wbc.more_io)
* become available for writeback. Otherwise
* we'll just busyloop.
*/
spin_lock(&inode_lock);
if (!list_empty(&wb->b_more_io)) {
inode = list_entry(
wb->b_more_io.prev,
struct inode, i_list);
inode_wait_for_writeback(inode);
}
spin_unlock(&inode_lock);
continue;
}
break; break;
/*
* Did we write something? Try for more
*/
if (wbc.nr_to_write < MAX_WRITEBACK_PAGES)
continue;
/*
* Nothing written. Wait for some inode to
* become available for writeback. Otherwise
* we'll just busyloop.
*/
spin_lock(&inode_lock);
if (!list_empty(&wb->b_more_io)) {
inode = list_entry(wb->b_more_io.prev,
struct inode, i_list);
inode_wait_for_writeback(inode);
} }
spin_unlock(&inode_lock);
} }
return wrote; return wrote;