[PATCH] mm: anon is already wrprotected
do_anonymous_page's pte_wrprotect causes some confusion: in such a case, vm_page_prot must already be forcing COW, so must omit write permission, and so the pte_wrprotect is redundant. Replace it by a comment to that effect, and reword the comment on unuse_pte which also caused confusion. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
committed by
Linus Torvalds
parent
6237bcd948
commit
72866f6f27
@@ -398,10 +398,9 @@ void free_swap_and_cache(swp_entry_t entry)
|
||||
}
|
||||
|
||||
/*
|
||||
* Always set the resulting pte to be nowrite (the same as COW pages
|
||||
* after one process has exited). We don't know just how many PTEs will
|
||||
* share this swap entry, so be cautious and let do_wp_page work out
|
||||
* what to do if a write is requested later.
|
||||
* No need to decide whether this PTE shares the swap entry with others,
|
||||
* just let do_wp_page work it out if a write is requested later - to
|
||||
* force COW, vm_page_prot omits write permission from any private vma.
|
||||
*
|
||||
* vma->vm_mm->page_table_lock is held.
|
||||
*/
|
||||
|
Reference in New Issue
Block a user