lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SCSI] sym53c416: kill pointless irq handler loop and test

Browse Source 
- kill pointless irq handler loop to find base address, it is already
  passed to irq handler via Scsi_Host.

- kill now-pointless !base test.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
This commit is contained in:
Jeff Garzik
2007-12-13 16:14:13 -08:00
committed by James Bottomley
parent baa9aac6a1
commit 736f77deaf
1 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/scsi/sym53c416.c
View File

@@ -328,27 +328,13 @@ static __inline__ unsigned int sym53c416_write(int base, unsigned char *buffer,
static irqreturn_t sym53c416_intr_handle(int irq, void *dev_id) static irqreturn_t sym53c416_intr_handle(int irq, void *dev_id)
{ {
struct Scsi_Host *dev = dev_id; struct Scsi_Host *dev = dev_id;
int base = 0; int base = dev->io_port;
int i; int i;
unsigned long flags = 0; unsigned long flags = 0;
unsigned char status_reg, pio_int_reg, int_reg; unsigned char status_reg, pio_int_reg, int_reg;
struct scatterlist *sg; struct scatterlist *sg;
unsigned int tot_trans = 0; unsigned int tot_trans = 0;
/* We search the base address of the host adapter which caused the interrupt */
/* FIXME: should pass dev_id sensibly as hosts[i] */
for(i = 0; i < host_index && !base; i++)
if(irq == hosts[i].irq)
base = hosts[i].base;
/* If no adapter found, we cannot handle the interrupt. Leave a message */
/* and continue. This should never happen... */
if(!base)
{
printk(KERN_ERR "sym53c416: No host adapter defined for interrupt %d\n", irq);
return IRQ_NONE;
}
/* Now we have the base address and we can start handling the interrupt */
spin_lock_irqsave(dev->host_lock,flags); spin_lock_irqsave(dev->host_lock,flags);
status_reg = inb(base + STATUS_REG); status_reg = inb(base + STATUS_REG);
pio_int_reg = inb(base + PIO_INT_REG); pio_int_reg = inb(base + PIO_INT_REG);