lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] reiserfs: fix journaling issue regarding fsync()

Browse Source 
When write() extends a file(i_size is increased) and fsync() is called,
change of inode must be written to journaling area through fsync().
But,currently the i_trans_id is not correctly updated when i_size is
increased.  So fsync() does not kick the journal writer.

Reiserfs_file_write() already updates the transaction when blocks are
allocated, but the case when i_size increases and new blocks are not added
is not correctly treated.

Following patch fix this bug.

Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Chris Mason <mason@suse.com>
Cc: Hans Reiser <reiser@namesys.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Hisashi Hifumi
2006-07-10 04:43:56 -07:00
committed by Linus Torvalds
parent 0808925ea5
commit 73ce5934e2
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/reiserfs/file.c
View File

@@ -860,8 +860,12 @@ static int reiserfs_submit_file_region_for_write(struct reiserfs_transaction_han
// this sets the proper flags for O_SYNC to trigger a commit // this sets the proper flags for O_SYNC to trigger a commit
mark_inode_dirty(inode); mark_inode_dirty(inode);
reiserfs_write_unlock(inode->i_sb); reiserfs_write_unlock(inode->i_sb);
} else } else {
reiserfs_write_lock(inode->i_sb);
reiserfs_update_inode_transaction(inode);
mark_inode_dirty(inode); mark_inode_dirty(inode);
reiserfs_write_unlock(inode->i_sb);
}
sd_update = 1; sd_update = 1;
} }