lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

proc: cleanup: remove unused assignments

Browse Source 
I removed 3 unused assignments.  The first two get reset on the first
statement of their functions.  For "err" in root.c we don't return an
error and we don't use the variable again.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Dan Carpenter
2010-05-26 14:43:25 -07:00
committed by Linus Torvalds
parent b3ac022cb9
commit 73d3646029
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/proc/base.c
View File

@@ -2432,7 +2432,7 @@ static struct dentry *proc_base_instantiate(struct inode *dir,
const struct pid_entry *p = ptr; const struct pid_entry *p = ptr;
struct inode *inode; struct inode *inode;
struct proc_inode *ei; struct proc_inode *ei;
struct dentry *error = ERR_PTR(-EINVAL); struct dentry *error;
/* Allocate the inode */ /* Allocate the inode */
error = ERR_PTR(-ENOMEM); error = ERR_PTR(-ENOMEM);
@@ -2782,7 +2782,7 @@ out:
struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *nd) struct dentry *proc_pid_lookup(struct inode *dir, struct dentry * dentry, struct nameidata *nd)
{ {
struct dentry *result = ERR_PTR(-ENOENT); struct dentry *result;
struct task_struct *task; struct task_struct *task;
unsigned tgid; unsigned tgid;
struct pid_namespace *ns; struct pid_namespace *ns;

1
fs/proc/root.c
View File

@@ -110,7 +110,6 @@ void __init proc_root_init(void)
if (err) if (err)
return; return;
proc_mnt = kern_mount_data(&proc_fs_type, &init_pid_ns); proc_mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
err = PTR_ERR(proc_mnt);
if (IS_ERR(proc_mnt)) { if (IS_ERR(proc_mnt)) {
unregister_filesystem(&proc_fs_type); unregister_filesystem(&proc_fs_type);
return; return;