lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

xfs: don't assert fail on bad inode numbers

Browse Source 
Let the inode verifier do it's work by returning an error when we
fail to find correct magic numbers in an inode buffer.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
Dave Chinner
2013-09-03 21:47:38 +10:00
committed by Ben Myers
parent 46f9d2eb37
commit 74ffa796e1
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fs/xfs/xfs_inode_buf.c
View File

@@ -53,9 +53,8 @@ xfs_inobp_check(
i * mp->m_sb.sb_inodesize); i * mp->m_sb.sb_inodesize);
if (!dip->di_next_unlinked) { if (!dip->di_next_unlinked) {
xfs_alert(mp, xfs_alert(mp,
"Detected bogus zero next_unlinked field in incore inode buffer 0x%p.", "Detected bogus zero next_unlinked field in inode %d buffer 0x%llx.",
bp); i, (long long)bp->b_bn);
ASSERT(dip->di_next_unlinked);
} }
} }
} }
@@ -106,11 +105,10 @@ xfs_inode_buf_verify(
XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH, XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_HIGH,
mp, dip); mp, dip);
#ifdef DEBUG #ifdef DEBUG
xfs_emerg(mp, xfs_alert(mp,
"bad inode magic/vsn daddr %lld #%d (magic=%x)", "bad inode magic/vsn daddr %lld #%d (magic=%x)",
(unsigned long long)bp->b_bn, i, (unsigned long long)bp->b_bn, i,
be16_to_cpu(dip->di_magic)); be16_to_cpu(dip->di_magic));
ASSERT(0);
#endif #endif
} }
} }