lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ALSA] sound/core/control.c: hard-irq-safe -> hard-irq-unsafe lock warning

Browse Source 
The lock grabbed in snd_ctl_empty_read_queue() is hardirq-unsafe but we hold
an hardirq-safe one already, so make the &ctl->read_lock also hard-irq-safe.

Signed-off-by: Borislav Petkov <bbpetkov@yahoo.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This commit is contained in:
Borislav Petkov
2007-10-22 17:11:09 +02:00
committed by Jaroslav Kysela
parent 31127f2eb9
commit 7507e8da2f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sound/core/control.c
View File

@@ -93,15 +93,16 @@ static int snd_ctl_open(struct inode *inode, struct file *file)
static void snd_ctl_empty_read_queue(struct snd_ctl_file * ctl) static void snd_ctl_empty_read_queue(struct snd_ctl_file * ctl)
{ {
unsigned long flags;
struct snd_kctl_event *cread; struct snd_kctl_event *cread;
spin_lock(&ctl->read_lock); spin_lock_irqsave(&ctl->read_lock, flags);
while (!list_empty(&ctl->events)) { while (!list_empty(&ctl->events)) {
cread = snd_kctl_event(ctl->events.next); cread = snd_kctl_event(ctl->events.next);
list_del(&cread->list); list_del(&cread->list);
kfree(cread); kfree(cread);
} }
spin_unlock(&ctl->read_lock); spin_unlock_irqrestore(&ctl->read_lock, flags);
} }
static int snd_ctl_release(struct inode *inode, struct file *file) static int snd_ctl_release(struct inode *inode, struct file *file)