lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Staging: vme: Add syncronize interrupts before removing callback

Browse Source 
As identified by Jiri, there is no syncronisation before callback is removed.

Signed-off-by: Martyn Welch <martyn.welch@gefanuc.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Martyn Welch
2009-08-11 13:50:49 +01:00
committed by Greg Kroah-Hartman
parent 51a569f757
commit 75155020c8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/vme/bridges/vme_tsi148.c
View File

@@ -480,6 +480,7 @@ int tsi148_request_irq(int level, int statid,
void tsi148_free_irq(int level, int statid) void tsi148_free_irq(int level, int statid)
{ {
u32 tmp; u32 tmp;
struct pci_dev *pdev;
/* Get semaphore */ /* Get semaphore */
down(&(vme_irq)); down(&(vme_irq));
@@ -495,6 +496,10 @@ void tsi148_free_irq(int level, int statid)
tmp = ioread32be(tsi148_bridge->base + TSI148_LCSR_INTEO); tmp = ioread32be(tsi148_bridge->base + TSI148_LCSR_INTEO);
tmp &= ~TSI148_LCSR_INTEO_IRQEO[level - 1]; tmp &= ~TSI148_LCSR_INTEO_IRQEO[level - 1];
iowrite32be(tmp, tsi148_bridge->base + TSI148_LCSR_INTEO); iowrite32be(tmp, tsi148_bridge->base + TSI148_LCSR_INTEO);
pdev = container_of(tsi148_bridge->parent, struct pci_dev, dev);
synchronize_irq(pdev->irq);
} }
tsi148_bridge->irq[level - 1].callback[statid].func = NULL; tsi148_bridge->irq[level - 1].callback[statid].func = NULL;