Merge branch 'task_killable' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc
* 'task_killable' of git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc: (22 commits) Remove commented-out code copied from NFS NFS: Switch from intr mount option to TASK_KILLABLE Add wait_for_completion_killable Add wait_event_killable Add schedule_timeout_killable Use mutex_lock_killable in vfs_readdir Add mutex_lock_killable Use lock_page_killable Add lock_page_killable Add fatal_signal_pending Add TASK_WAKEKILL exit: Use task_is_* signal: Use task_is_* sched: Use task_contributes_to_load, TASK_ALL and TASK_NORMAL ptrace: Use task_is_* power: Use task_is_* wait: Use TASK_NORMAL proc/base.c: Use task_is_* proc/array.c: Use TASK_REPORT perfmon: Use task_is_* ... Fixed up conflicts in NFS/sunrpc manually..
This commit is contained in:
@@ -386,7 +386,7 @@ found_client:
|
||||
if (new)
|
||||
nfs_free_client(new);
|
||||
|
||||
error = wait_event_interruptible(nfs_client_active_wq,
|
||||
error = wait_event_killable(nfs_client_active_wq,
|
||||
clp->cl_cons_state != NFS_CS_INITING);
|
||||
if (error < 0) {
|
||||
nfs_put_client(clp);
|
||||
@@ -589,10 +589,6 @@ static int nfs_init_server_rpcclient(struct nfs_server *server,
|
||||
if (server->flags & NFS_MOUNT_SOFT)
|
||||
server->client->cl_softrtry = 1;
|
||||
|
||||
server->client->cl_intr = 0;
|
||||
if (server->flags & NFS4_MOUNT_INTR)
|
||||
server->client->cl_intr = 1;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
@@ -188,17 +188,12 @@ static void nfs_direct_req_release(struct nfs_direct_req *dreq)
|
||||
static ssize_t nfs_direct_wait(struct nfs_direct_req *dreq)
|
||||
{
|
||||
ssize_t result = -EIOCBQUEUED;
|
||||
struct rpc_clnt *clnt;
|
||||
sigset_t oldset;
|
||||
|
||||
/* Async requests don't wait here */
|
||||
if (dreq->iocb)
|
||||
goto out;
|
||||
|
||||
clnt = NFS_CLIENT(dreq->inode);
|
||||
rpc_clnt_sigmask(clnt, &oldset);
|
||||
result = wait_for_completion_interruptible(&dreq->completion);
|
||||
rpc_clnt_sigunmask(clnt, &oldset);
|
||||
result = wait_for_completion_killable(&dreq->completion);
|
||||
|
||||
if (!result)
|
||||
result = dreq->error;
|
||||
|
@@ -433,15 +433,11 @@ static int nfs_wait_schedule(void *word)
|
||||
*/
|
||||
static int nfs_wait_on_inode(struct inode *inode)
|
||||
{
|
||||
struct rpc_clnt *clnt = NFS_CLIENT(inode);
|
||||
struct nfs_inode *nfsi = NFS_I(inode);
|
||||
sigset_t oldmask;
|
||||
int error;
|
||||
|
||||
rpc_clnt_sigmask(clnt, &oldmask);
|
||||
error = wait_on_bit_lock(&nfsi->flags, NFS_INO_REVALIDATING,
|
||||
nfs_wait_schedule, TASK_INTERRUPTIBLE);
|
||||
rpc_clnt_sigunmask(clnt, &oldmask);
|
||||
nfs_wait_schedule, TASK_KILLABLE);
|
||||
|
||||
return error;
|
||||
}
|
||||
|
@@ -56,7 +56,7 @@ int nfs_mount(struct sockaddr *addr, size_t len, char *hostname, char *path,
|
||||
.program = &mnt_program,
|
||||
.version = version,
|
||||
.authflavor = RPC_AUTH_UNIX,
|
||||
.flags = RPC_CLNT_CREATE_INTR,
|
||||
.flags = 0,
|
||||
};
|
||||
struct rpc_clnt *mnt_clnt;
|
||||
int status;
|
||||
|
@@ -27,17 +27,14 @@
|
||||
static int
|
||||
nfs3_rpc_wrapper(struct rpc_clnt *clnt, struct rpc_message *msg, int flags)
|
||||
{
|
||||
sigset_t oldset;
|
||||
int res;
|
||||
rpc_clnt_sigmask(clnt, &oldset);
|
||||
do {
|
||||
res = rpc_call_sync(clnt, msg, flags);
|
||||
if (res != -EJUKEBOX)
|
||||
break;
|
||||
schedule_timeout_interruptible(NFS_JUKEBOX_RETRY_TIME);
|
||||
schedule_timeout_killable(NFS_JUKEBOX_RETRY_TIME);
|
||||
res = -ERESTARTSYS;
|
||||
} while (!signalled());
|
||||
rpc_clnt_sigunmask(clnt, &oldset);
|
||||
} while (!fatal_signal_pending(current));
|
||||
return res;
|
||||
}
|
||||
|
||||
|
@@ -316,12 +316,9 @@ static void nfs4_opendata_put(struct nfs4_opendata *p)
|
||||
|
||||
static int nfs4_wait_for_completion_rpc_task(struct rpc_task *task)
|
||||
{
|
||||
sigset_t oldset;
|
||||
int ret;
|
||||
|
||||
rpc_clnt_sigmask(task->tk_client, &oldset);
|
||||
ret = rpc_wait_for_completion_task(task);
|
||||
rpc_clnt_sigunmask(task->tk_client, &oldset);
|
||||
return ret;
|
||||
}
|
||||
|
||||
@@ -2785,9 +2782,9 @@ nfs4_async_handle_error(struct rpc_task *task, const struct nfs_server *server)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int nfs4_wait_bit_interruptible(void *word)
|
||||
static int nfs4_wait_bit_killable(void *word)
|
||||
{
|
||||
if (signal_pending(current))
|
||||
if (fatal_signal_pending(current))
|
||||
return -ERESTARTSYS;
|
||||
schedule();
|
||||
return 0;
|
||||
@@ -2795,18 +2792,14 @@ static int nfs4_wait_bit_interruptible(void *word)
|
||||
|
||||
static int nfs4_wait_clnt_recover(struct rpc_clnt *clnt, struct nfs_client *clp)
|
||||
{
|
||||
sigset_t oldset;
|
||||
int res;
|
||||
|
||||
might_sleep();
|
||||
|
||||
rwsem_acquire(&clp->cl_sem.dep_map, 0, 0, _RET_IP_);
|
||||
|
||||
rpc_clnt_sigmask(clnt, &oldset);
|
||||
res = wait_on_bit(&clp->cl_state, NFS4CLNT_STATE_RECOVER,
|
||||
nfs4_wait_bit_interruptible,
|
||||
TASK_INTERRUPTIBLE);
|
||||
rpc_clnt_sigunmask(clnt, &oldset);
|
||||
nfs4_wait_bit_killable, TASK_KILLABLE);
|
||||
|
||||
rwsem_release(&clp->cl_sem.dep_map, 1, _RET_IP_);
|
||||
return res;
|
||||
@@ -2814,7 +2807,6 @@ static int nfs4_wait_clnt_recover(struct rpc_clnt *clnt, struct nfs_client *clp)
|
||||
|
||||
static int nfs4_delay(struct rpc_clnt *clnt, long *timeout)
|
||||
{
|
||||
sigset_t oldset;
|
||||
int res = 0;
|
||||
|
||||
might_sleep();
|
||||
@@ -2823,14 +2815,9 @@ static int nfs4_delay(struct rpc_clnt *clnt, long *timeout)
|
||||
*timeout = NFS4_POLL_RETRY_MIN;
|
||||
if (*timeout > NFS4_POLL_RETRY_MAX)
|
||||
*timeout = NFS4_POLL_RETRY_MAX;
|
||||
rpc_clnt_sigmask(clnt, &oldset);
|
||||
if (clnt->cl_intr) {
|
||||
schedule_timeout_interruptible(*timeout);
|
||||
if (signalled())
|
||||
res = -ERESTARTSYS;
|
||||
} else
|
||||
schedule_timeout_uninterruptible(*timeout);
|
||||
rpc_clnt_sigunmask(clnt, &oldset);
|
||||
schedule_timeout_killable(*timeout);
|
||||
if (fatal_signal_pending(current))
|
||||
res = -ERESTARTSYS;
|
||||
*timeout <<= 1;
|
||||
return res;
|
||||
}
|
||||
@@ -3069,7 +3056,7 @@ int nfs4_proc_delegreturn(struct inode *inode, struct rpc_cred *cred, const nfs4
|
||||
static unsigned long
|
||||
nfs4_set_lock_task_retry(unsigned long timeout)
|
||||
{
|
||||
schedule_timeout_interruptible(timeout);
|
||||
schedule_timeout_killable(timeout);
|
||||
timeout <<= 1;
|
||||
if (timeout > NFS4_LOCK_MAXTIMEOUT)
|
||||
return NFS4_LOCK_MAXTIMEOUT;
|
||||
|
@@ -228,10 +228,7 @@ static int __init root_nfs_parse(char *name, char *buf)
|
||||
nfs_data.flags &= ~NFS_MOUNT_SOFT;
|
||||
break;
|
||||
case Opt_intr:
|
||||
nfs_data.flags |= NFS_MOUNT_INTR;
|
||||
break;
|
||||
case Opt_nointr:
|
||||
nfs_data.flags &= ~NFS_MOUNT_INTR;
|
||||
break;
|
||||
case Opt_posix:
|
||||
nfs_data.flags |= NFS_MOUNT_POSIX;
|
||||
|
@@ -58,7 +58,6 @@ nfs_create_request(struct nfs_open_context *ctx, struct inode *inode,
|
||||
struct page *page,
|
||||
unsigned int offset, unsigned int count)
|
||||
{
|
||||
struct nfs_server *server = NFS_SERVER(inode);
|
||||
struct nfs_page *req;
|
||||
|
||||
for (;;) {
|
||||
@@ -67,7 +66,7 @@ nfs_create_request(struct nfs_open_context *ctx, struct inode *inode,
|
||||
if (req != NULL)
|
||||
break;
|
||||
|
||||
if (signalled() && (server->flags & NFS_MOUNT_INTR))
|
||||
if (fatal_signal_pending(current))
|
||||
return ERR_PTR(-ERESTARTSYS);
|
||||
yield();
|
||||
}
|
||||
@@ -177,11 +176,11 @@ void nfs_release_request(struct nfs_page *req)
|
||||
kref_put(&req->wb_kref, nfs_free_request);
|
||||
}
|
||||
|
||||
static int nfs_wait_bit_interruptible(void *word)
|
||||
static int nfs_wait_bit_killable(void *word)
|
||||
{
|
||||
int ret = 0;
|
||||
|
||||
if (signal_pending(current))
|
||||
if (fatal_signal_pending(current))
|
||||
ret = -ERESTARTSYS;
|
||||
else
|
||||
schedule();
|
||||
@@ -192,26 +191,18 @@ static int nfs_wait_bit_interruptible(void *word)
|
||||
* nfs_wait_on_request - Wait for a request to complete.
|
||||
* @req: request to wait upon.
|
||||
*
|
||||
* Interruptible by signals only if mounted with intr flag.
|
||||
* Interruptible by fatal signals only.
|
||||
* The user is responsible for holding a count on the request.
|
||||
*/
|
||||
int
|
||||
nfs_wait_on_request(struct nfs_page *req)
|
||||
{
|
||||
struct rpc_clnt *clnt = NFS_CLIENT(req->wb_context->path.dentry->d_inode);
|
||||
sigset_t oldmask;
|
||||
int ret = 0;
|
||||
|
||||
if (!test_bit(PG_BUSY, &req->wb_flags))
|
||||
goto out;
|
||||
/*
|
||||
* Note: the call to rpc_clnt_sigmask() suffices to ensure that we
|
||||
* are not interrupted if intr flag is not set
|
||||
*/
|
||||
rpc_clnt_sigmask(clnt, &oldmask);
|
||||
ret = out_of_line_wait_on_bit(&req->wb_flags, PG_BUSY,
|
||||
nfs_wait_bit_interruptible, TASK_INTERRUPTIBLE);
|
||||
rpc_clnt_sigunmask(clnt, &oldmask);
|
||||
nfs_wait_bit_killable, TASK_KILLABLE);
|
||||
out:
|
||||
return ret;
|
||||
}
|
||||
|
@@ -448,7 +448,6 @@ static void nfs_show_mount_options(struct seq_file *m, struct nfs_server *nfss,
|
||||
const char *nostr;
|
||||
} nfs_info[] = {
|
||||
{ NFS_MOUNT_SOFT, ",soft", ",hard" },
|
||||
{ NFS_MOUNT_INTR, ",intr", ",nointr" },
|
||||
{ NFS_MOUNT_NOCTO, ",nocto", "" },
|
||||
{ NFS_MOUNT_NOAC, ",noac", "" },
|
||||
{ NFS_MOUNT_NONLM, ",nolock", "" },
|
||||
@@ -708,10 +707,7 @@ static int nfs_parse_mount_options(char *raw,
|
||||
mnt->flags &= ~NFS_MOUNT_SOFT;
|
||||
break;
|
||||
case Opt_intr:
|
||||
mnt->flags |= NFS_MOUNT_INTR;
|
||||
break;
|
||||
case Opt_nointr:
|
||||
mnt->flags &= ~NFS_MOUNT_INTR;
|
||||
break;
|
||||
case Opt_posix:
|
||||
mnt->flags |= NFS_MOUNT_POSIX;
|
||||
|
@@ -488,7 +488,7 @@ int nfs_reschedule_unstable_write(struct nfs_page *req)
|
||||
/*
|
||||
* Wait for a request to complete.
|
||||
*
|
||||
* Interruptible by signals only if mounted with intr flag.
|
||||
* Interruptible by fatal signals only.
|
||||
*/
|
||||
static int nfs_wait_on_requests_locked(struct inode *inode, pgoff_t idx_start, unsigned int npages)
|
||||
{
|
||||
|
Reference in New Issue
Block a user